URL: https://github.com/SSSD/sssd/pull/312
Author: lslebodn
 Title: #312: Master valgrind
Action: opened

PR body:
"""
There was a bug in valgrind < 3.13 which override some log files
and therefore there was missing errors for shell wrappers generated
by libtool for dummy-child.
    
https://bugs.kde.org/show_bug.cgi?id=162848
    
We could add more suppressions for errors/leaks in bash to our suppression
file but dummy child is built just for test purposes. Another possible solution
would to avoid linking dummy-child with internal libraries; So libtool
would not generate shell wrapper for dummy-child.
But the simplest think is to ignore all errors for dummy-child.

current master:
http://sssd-ci.duckdns.org/logs/job/71/50/summary.html

This patchset:
http://sssd-ci.duckdns.org/logs/job/71/51/summary.html
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/312/head:pr312
git checkout pr312
From 6cc40889fcd021d2654253c0e5bfd452e92b3cac Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik <lsleb...@redhat.com>
Date: Sat, 17 Jun 2017 14:10:23 +0200
Subject: [PATCH 1/2] CI: Do not use valgrind for dummy-child

There was a bug in valgrind < 3.13 which override some log files
and therefore there was missing errors for shell wrappers generated
by libtool for dummy-child.

https://bugs.kde.org/show_bug.cgi?id=162848

We could add more suppressions for errors/leaks in bash to our suppression
file but dummy child is built just for test purposes. Another possible solution
would to avoid linking dummy-child with internal libraries; So libtool
would not generate shell wrapper for dummy-child.
But the simplest think is to ignore all errors for dummy-child.
---
 contrib/ci/run | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/contrib/ci/run b/contrib/ci/run
index a2f7f4f2d..fb72a33ac 100755
--- a/contrib/ci/run
+++ b/contrib/ci/run
@@ -214,7 +214,7 @@ function build_debug()
                                 valgrind-condense 99 \
                                 \"$valgrind_test_pattern\" -- \
                                 --trace-children=yes \
-                                --trace-children-skip='*/bin/*,*/sbin/*' \
+                                --trace-children-skip='*/bin/*,*/sbin/*,./dummy-child' \
                                 --leak-check=full \
                                 --gen-suppressions=all \
                                 --suppressions=\"$CI_DIR/sssd.supp\" \

From 3c2f0c64d00c47fba7e050786fe54e43624fa723 Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik <lsleb...@redhat.com>
Date: Sat, 17 Jun 2017 14:11:37 +0200
Subject: [PATCH 2/2] Revert "CI: Use /bin/sh as a CONFIG SHELL"

This reverts commit 35f29b17699c3d52f77857c530300318b14148f8.

Workaround is not required anymore.
---
 contrib/ci/run | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/contrib/ci/run b/contrib/ci/run
index fb72a33ac..aa6d35abe 100755
--- a/contrib/ci/run
+++ b/contrib/ci/run
@@ -199,8 +199,7 @@ function build_debug()
     test_dir=`mktemp --directory /dev/shm/ci-test-dir.XXXXXXXX`
     stage configure         "$BASE_DIR/configure" \
                                 "${CONFIGURE_ARG_LIST[@]}" \
-                                --with-test-dir="$test_dir" \
-                                SHELL=/bin/sh
+                                --with-test-dir="$test_dir"
 
     # Not building "tests" due to https://fedorahosted.org/sssd/ticket/2350
     stage make-tests        make -j $CPU_NUM check LOG_COMPILER=true
_______________________________________________
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

Reply via email to