URL: https://github.com/SSSD/sssd/pull/326 Title: #326: IPA: check if IPA hostname is a FQDN
fidencio commented: """ @amitkumar50 ... this patch itself looks good and works as expected. I'm wondering, though, whether the sssd-ipa man page should be updated as well (as a first patch) in order to mention that the ipa_hostname option **must** be fully-qualified and then, in this patch, mention something like "ipa_hostname must be a fully-qualified name, please refer to the sssd-ipa manpage for more information" to this patch you've submitted. Let me know if you're willing to make the change. In a negative case I can provide the patch and rebase yours on top of mine. Thanks for the contribution! (I'm adding the "Changes Requested" label as per this review). """ See the full comment at https://github.com/SSSD/sssd/pull/326#issuecomment-320797156
_______________________________________________ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
