URL: https://github.com/SSSD/sssd/pull/373
Title: #373: intg: Add sanity tests for pysss_nss_idmap

fidencio commented:
"""
@lslebodn, when running the tests locally I noticed a lot of fails due to a 
missing replacement, this patch is enough to fix it:

```
diff --git a/src/tests/intg/ds_openldap.py b/src/tests/intg/ds_openldap.py
index ccdff4cc8..842ff9108 100644
--- a/src/tests/intg/ds_openldap.py
+++ b/src/tests/intg/ds_openldap.py
@@ -245,7 +245,7 @@ class DSOpenLDAP(DS):
              b"STRUCTURAL MUST ( cn ) MAY ( member $ businessCategory $ "
              b"seeAlso $ owner $ ou $ o $ description ) )"),
         ]
-        ldap_conn = ldap.initialize(ldapi_url)
+        ldap_conn = ldap.initialize(self.ldapi_url)
         ldap_conn.simple_bind_s(self.admin_rdn + ",cn=config", self.admin_pw)
         ldap_conn.modify_s("cn={0}core,cn=schema,cn=config", modlist)
         ldap_conn.unbind_s()
```

Please, squash it in your patches.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/373#issuecomment-328439041
_______________________________________________
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

Reply via email to