URL: https://github.com/SSSD/sssd/pull/457 Author: amitkumar50 Title: #457: ipa: Removal of umask(0) in selinux_child Action: opened
PR body: """ Code for calling umask(0) was added to address bugzilla https://bugzilla.redhat.com/show_bug.cgi?id=1186422. Now this bugzilla is fixed, removing the workaround. Resolves: https://pagure.io/SSSD/sssd/issue/3583 """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/457/head:pr457 git checkout pr457
From 85710d7569ca3e930761432247ca2bac5389fe2f Mon Sep 17 00:00:00 2001 From: amitkuma <[email protected]> Date: Wed, 22 Nov 2017 17:25:21 +0530 Subject: [PATCH] ipa: Removal of umask(0) in selinux_child Code for calling umask(0) was added to address bugzilla https://bugzilla.redhat.com/show_bug.cgi?id=1186422. Now this bugzilla is fixed, removing the workaround. Resolves: https://pagure.io/SSSD/sssd/issue/3583 --- src/providers/ipa/selinux_child.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/providers/ipa/selinux_child.c b/src/providers/ipa/selinux_child.c index a7e20f715..08a4271c6 100644 --- a/src/providers/ipa/selinux_child.c +++ b/src/providers/ipa/selinux_child.c @@ -146,13 +146,6 @@ static int sc_set_seuser(const char *login_name, const char *seuser_name, const char *mls) { int ret; - mode_t old_mask; - - /* This is a workaround for - * https://bugzilla.redhat.com/show_bug.cgi?id=1186422 to make sure - * the directories are created with the expected permissions - */ - old_mask = umask(0); if (strcmp(seuser_name, "") == 0) { /* An empty SELinux user should cause SSSD to use the system * default. We need to remove the SELinux user from the DB @@ -162,7 +155,6 @@ static int sc_set_seuser(const char *login_name, const char *seuser_name, } else { ret = set_seuser(login_name, seuser_name, mls); } - umask(old_mask); return ret; }
_______________________________________________ sssd-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]
