URL: https://github.com/SSSD/sssd/pull/480 Title: #480: MAN: Describe the constrains of ipa_server_mode better in the man page
mzidek-rh commented: """ Hi @amitkumar50! I am not native English speaker and I do often make mistakes when I use English, so I definitely do not want to sound like a grammar nazi :) but your argument against the use of 'that' in the 'sentence A' (see below) does not look valid (visit this link for explanation: https://www.thoughtco.com/uses-of-that-1210017 ). Also 'sentence B' (that you proposed) does not look right to me. It could be corrected by putting period after 'assumptions' and splitting the sentence into two sentences. But I think the original 'sentence A' is still better. This is why we usually request native speakers to double check after us and Justin (native speaker) was also fine with the sentence A. So IMO we can remove the changes requested label. Sentence A: There are currently some assumptions that must be met when SSSD is running on an IPA server. Sentence B: There are currently some assumptions those must be fulfilled when SSSD is running on an IPA server. """ See the full comment at https://github.com/SSSD/sssd/pull/480#issuecomment-355071467
_______________________________________________ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
