On Wed, Jan 10, 2018 at 10:52:56AM +0100, Sumit Bose wrote: > On Wed, Jan 10, 2018 at 10:04:49AM +0100, Fabiano FidĂȘncio wrote: > > People, > > > > Ideally every PR should come with a test (unit, integration, ...), but > > unfortunately we're a little bit far from the ideal situation. Thus, I'd > > like to ask whether we have documented somewhere (apart from our code > > itself) which are the parts of SSSD code that can be easily tested by our > > unit and integration tests. > > > > My understanding (and please, correct me if I'm mistaken) is that by having > > a updated list of our tests coverage would help any newcomer submitting > > something new to the project and also not so experienced reviewers to > > easily detect that a PR touching this or that part would need a test > > (otherwise we don't even start reviewing the patches). > > > > So, does this list exist somewhere? Would be a fair request to create this > > list and have it linked to our "Contribute" page? > > iirc the CI scripts create coverage data. Would this help?
I guess partially, because it looks like only unit tests (and not integration tests) are generating the coverage. Also, I think this question comes from https://github.com/SSSD/sssd/pull/476 and there the test would have to be written in the IPA tree (there are already some tests for netgroups) _______________________________________________ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org