URL: https://github.com/SSSD/sssd/pull/128
Title: #128: Fix group renaming issue when "id_provider = ldap" is set

sumit-bose commented:
"""
@fidencio, you cannot do this on the sysdb level, that's the wrong layer. 
sysdb_add_incomplete_group() is called in only two places. So I would suggest 
instead to deleting the old entry in sysdb_add_incomplete_group() to return a 
specific error code so that the caller knows about the rename, remove the old 
group on its own, call sysdb_add_incomplete_group() again to add the new entry.

The two callers call  sysdb_add_incomplete_group() in a loop. So just returning 
an error code here to notify the next layer would not work. But since it is 
already in the general LDAP code if might be easier to pass down the needed 
contexts to make the dbus calls. As an alternative the callers can return a 
list of objects which have to be deleted from the memory cache so that some 
upper layers can handle them.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/128#issuecomment-366324379
_______________________________________________
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

Reply via email to