URL: https://github.com/SSSD/sssd/pull/464 Title: #464: SYSDB: Properly handle name/gid override when using domain resolution order
sumit-bose commented: """ Ok, I agree that the readability is not improved a lot by my suggestion. I run some manual tests and didn't found issues and the original issue is solved by the patch as well. CI went well as well http://vm/logs/job/88/98/summary.html. Unfortunately I came across a case which might need some improvement. For the pure mpg case where SYSDB_GRNAM_MPG_FILTER is the right filter the new version runs the same ldb_search two times (if I see it correctly). Can you add some checks so that the second ldb_search is skipped for this case? """ See the full comment at https://github.com/SSSD/sssd/pull/464#issuecomment-387079835
_______________________________________________ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
