URL: https://github.com/SSSD/sssd/pull/573 Author: sumit-bose Title: #573: winbind idmap plugin: fix detection Action: opened
PR body: """ Currently when compiling the detection code for the idmap interface version only SMBCLIENT_CFLAGS are used. Since libsmbclient does not use NTSTATUS the cflags do not contain '-DHAVE_IMMEDIATE_STRUCTURES=1' which make NTSTATUS to a struct instead of an integer. Since Samba itself might be complied with this define (it typically is) we have to make sure we use it as well. Otherwise the test program might crash on platforms where this change changes the calling convention as well. Related to https://pagure.io/SSSD/sssd/issue/3741 """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/573/head:pr573 git checkout pr573
From 9d4cfbd277f50f992169f19bc2477cb3cd16b1c0 Mon Sep 17 00:00:00 2001 From: Sumit Bose <sb...@redhat.com> Date: Fri, 18 May 2018 21:34:44 +0200 Subject: [PATCH] winbind idmap plugin: fix detection Currently when compiling the detection code for the idmap interface version only SMBCLIENT_CFLAGS are used. Since libsmbclient does not use NTSTATUS the cflags do not contain '-DHAVE_IMMEDIATE_STRUCTURES=1' which make NTSTATUS to a struct instead of an integer. Since Samba itself might be complied with this define (it typically is) we have to make sure we use it as well. Otherwise the test program might crash on platforms where this change changes the calling convention as well. Related to https://pagure.io/SSSD/sssd/issue/3741 --- src/external/samba.m4 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/external/samba.m4 b/src/external/samba.m4 index 610831bf0..a67e17dcb 100644 --- a/src/external/samba.m4 +++ b/src/external/samba.m4 @@ -59,7 +59,7 @@ them. In this case, you will need to execute configure script with argument sambalibdir="`$PKG_CONFIG --variable=libdir smbclient`"/samba SAVE_CFLAGS=$CFLAGS SAVE_LIBS=$LIBS - CFLAGS="$CFLAGS $SMBCLIENT_CFLAGS -I/usr/include/samba-4.0" + CFLAGS="$CFLAGS $SMBCLIENT_CFLAGS $NDR_NBT_CFLAGS $NDR_KRB5PAC_CFLAGS -I/usr/include/samba-4.0" LIBS="$LIBS -L${sambalibdir} -lidmap-samba4 -Wl,-rpath ${sambalibdir}" AC_RUN_IFELSE( [AC_LANG_SOURCE([ @@ -98,7 +98,7 @@ int main(void) /* Check the versions we know about */ for (v = 5; v <= 6; v++) { ret = smb_register_idmap(v, NULL, NULL); - if (ret != NT_STATUS_OBJECT_TYPE_MISMATCH) { + if (!NT_STATUS_EQUAL(ret,NT_STATUS_OBJECT_TYPE_MISMATCH)) { return v; } }
_______________________________________________ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/COI72J5ZCHIRM3TEFPWT4UAUFIWQPDB3/
