URL: https://github.com/SSSD/sssd/pull/601
Title: #601: sbus: integrate sssd with sbus2
pbrezina commented:
"""
Fixed IPA issue:
```diff
diff --git a/src/providers/data_provider/dp_target_auth.c
b/src/providers/data_provider/dp_target_auth.c
index 13874f9..02179dd 100644
--- a/src/providers/data_provider/dp_target_auth.c
+++ b/src/providers/data_provider/dp_target_auth.c
@@ -222,16 +222,16 @@ static void dp_pam_handler_auth_done(struct tevent_req
*subreq)
return;
}
- req = dp_req_send(state, state->provider, state->pd->domain,
- "PAM SELinux", DPT_SELINUX, DPM_SELINUX_HANDLER,
- 0, state->pd, NULL);
- if (req == NULL) {
+ subreq = dp_req_send(state, state->provider, state->pd->domain,
+ "PAM SELinux", DPT_SELINUX, DPM_SELINUX_HANDLER,
+ 0, state->pd, NULL);
+ if (subreq == NULL) {
DEBUG(SSSDBG_CRIT_FAILURE, "Unable to create subrequest!\n");
tevent_req_error(req, ENOMEM);
return;
}
- tevent_req_set_callback(req, dp_pam_handler_done, req);
+ tevent_req_set_callback(subreq, dp_pam_handler_done, req);
}
static void dp_pam_handler_done(struct tevent_req *subreq)
diff --git a/src/sss_iface/sss_iface_types.c b/src/sss_iface/sss_iface_types.c
index 3c0bbc0..b2b3098 100644
--- a/src/sss_iface/sss_iface_types.c
+++ b/src/sss_iface/sss_iface_types.c
@@ -311,7 +311,7 @@ errno_t sbus_iterator_read_pam_response(TALLOC_CTX *mem_ctx,
dbus_message_iter_recurse(&array_iter, &struct_iter);
- ret = sbus_iterator_read_u(iterator, &resp_type);
+ ret = sbus_iterator_read_u(&struct_iter, &resp_type);
if (ret != EOK) {
goto done;
}
```
"""
See the full comment at
https://github.com/SSSD/sssd/pull/601#issuecomment-409562828
_______________________________________________
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/WULCROYWNE3PDTOJKXO5YKG5VVQLPBQC/
