URL: https://github.com/SSSD/sssd/pull/651 Title: #651: test-library: fixes related to KCM, TLS on Directory server
jhrozek commented: """ LGTM. The commit still does too many things at once for my taste. I would prefer if you could split the commits into smaller ones that do just one thing - e.g. here we would have one commit that just adds the SSSDException, another that adds the LDAPException, another that works with the pkcs files etc. Then it gets much easier to review the PR. But for now, let's merge the PR as it is and let's improve with the subsequent PRs.. """ See the full comment at https://github.com/SSSD/sssd/pull/651#issuecomment-420280867
_______________________________________________ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
