URL: https://github.com/SSSD/sssd/pull/675 Author: jhrozek Title: #675: p11: Fix -Wmaybe-uninitialized in p11_child_openssl.c Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/675/head:pr675 git checkout pr675
From 5a73c08e3fc7cd0541cbb72dd35486cb02c6cb92 Mon Sep 17 00:00:00 2001 From: Jakub Hrozek <jhro...@redhat.com> Date: Fri, 12 Oct 2018 09:32:11 +0200 Subject: [PATCH] p11: Fix two instances of -Wmaybe-uninitialized in p11_child_openssl.c If uri_str was passed to the p11_child and parsing the URI failed, then modules would be uninitialized, but freed in the done handler with p11_kit_modules_finalize_and_release() Also, another warning is suppressed by setting the 's' variable to zero. While it cannot happen that the variable will be uninitialized, we should help the compiler by setting a value explicitly. --- src/p11_child/p11_child_openssl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/p11_child/p11_child_openssl.c b/src/p11_child/p11_child_openssl.c index 000e1c94f..cca5af24a 100644 --- a/src/p11_child/p11_child_openssl.c +++ b/src/p11_child/p11_child_openssl.c @@ -666,8 +666,8 @@ errno_t do_card(TALLOC_CTX *mem_ctx, struct p11_ctx *p11_ctx, { int ret; size_t c; - size_t s; - CK_FUNCTION_LIST **modules; + size_t s = 0; + CK_FUNCTION_LIST **modules = NULL; CK_FUNCTION_LIST *module = NULL; char *mod_name; char *mod_file_name;
_______________________________________________ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org