URL: https://github.com/SSSD/sssd/pull/677 Title: #677: pcre: port to pcre2
jhrozek commented: """ I added some style comments. Please don't take them the wrong way, I didn't mean to needlessly pick on your code (I think in general the patches are good!) but because SSSD is such a big project already with a long development history, I just think it's quite important for all modules to look quite similar. """ See the full comment at https://github.com/SSSD/sssd/pull/677#issuecomment-430355081
_______________________________________________ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
