URL: https://github.com/SSSD/sssd/pull/697
Author: jhrozek
Title: #697: RESPONDER: Log failures from bind() and listen()
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/697/head:pr697
git checkout pr697
From aae911ec5d4423ce0dfd6da3bb67a0c7e43e1ce2 Mon Sep 17 00:00:00 2001
From: Jakub Hrozek <jhro...@redhat.com>
Date: Tue, 20 Nov 2018 12:16:44 +0100
Subject: [PATCH] RESPONDER: Log failures from bind() and listen()
We've seen reports from users where SSSD (for a reason which is not
known at the moment) couldn't bind to the created socket. This patch
just logs the errno which should help in debugging issues like that in
the future.
---
src/responder/common/responder_common.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/src/responder/common/responder_common.c b/src/responder/common/responder_common.c
index 9081901a66..5792f3aaaa 100644
--- a/src/responder/common/responder_common.c
+++ b/src/responder/common/responder_common.c
@@ -847,15 +847,18 @@ int create_pipe_fd(const char *sock_name, int *_fd, mode_t umaskval)
}
if (bind(fd, (struct sockaddr *)&addr, sizeof(addr)) == -1) {
+ ret = errno;
DEBUG(SSSDBG_FATAL_FAILURE,
- "Unable to bind on socket '%s'\n", sock_name);
- ret = EIO;
+ "Unable to bind on socket '%s' [%d]: %s\n",
+ sock_name, ret, sss_strerror(ret));
goto done;
}
+
if (listen(fd, 10) == -1) {
+ ret = errno;
DEBUG(SSSDBG_FATAL_FAILURE,
- "Unable to listen on socket '%s'\n", sock_name);
- ret = EIO;
+ "Unable to listen on socket '%s' [%d]: %s\n",
+ sock_name, ret, sss_strerror(ret));
goto done;
}
_______________________________________________
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
