URL: https://github.com/SSSD/sssd/pull/713 Title: #713: krb5_child: fix permissions during SC auth
jhrozek commented: """ In general this looks good, but please fix this clang warning: ``` Error: CLANG_WARNING: sssd-2.0.99/src/providers/krb5/krb5_child.c:1759:13: warning: Value stored to 'ret' is never read # ret = EFAULT; # ^ ~~~~~~ sssd-2.0.99/src/providers/krb5/krb5_child.c:1759:13: note: Value stored to 'ret' is never read # ret = EFAULT; # ^ ~~~~~~ # 1757| if (kerr != 0) { # 1758| DEBUG(SSSDBG_CRIT_FAILURE, "become_user failed.\n"); # 1759|-> ret = EFAULT; # 1760| goto done; # 1761| } (The function returns the value of kerr, not ret) ``` """ See the full comment at https://github.com/SSSD/sssd/pull/713#issuecomment-446533287
_______________________________________________ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org