URL: https://github.com/SSSD/sssd/pull/843 Title: #843: p11_child: prefer better digest function if card supports it
alexey-tikhonov commented: """ Again unrelated to this patch but too minor to open stand alone issue (sorry I missed it previously): (1) `do_hash()` function: why is `md_ctx` only freed in case `(ret != EOK)`? (2) `sign_data`: it seems `hash_val` (allocated in `do_hash()`) is leaking. It is allocated in the context of `cert` thus not "totally lost". But `signature` (that is also allocated in the context of `cert`) is freed in cleanup section. So I guess `hash_val` also should be freed... Otherwise ACK code-wise. Internal CI and covscan checks are fine as well. But I still need to setup env to verify patch manually. """ See the full comment at https://github.com/SSSD/sssd/pull/843#issuecomment-508104269
_______________________________________________ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
