URL: https://github.com/SSSD/sssd/pull/838
Title: #838: FIPS140 compliant usage of PRNG

alexey-tikhonov commented:
"""
Hi @pbrezina,

Thanks for the review.

> there are few minor coding style violations but otherwise I accept these 
> patches. 

I rebased patches and addressed all comments.

> there are multiple new lines around `sss_rand()` functions, only one empty 
> line should be there

I changed this as well, but actually I was unable to find such a requirement in 
[Coding 
guidelines](https://docs.pagure.org/SSSD.sssd/developers/coding_style.html).
Do you think guide should be updated?


"""

See the full comment at 
https://github.com/SSSD/sssd/pull/838#issuecomment-509312412
_______________________________________________
sssd-devel mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/[email protected]

Reply via email to