URL: https://github.com/SSSD/sssd/pull/883 Title: #883: Minor fixes to util/sss_krb5
alexey-tikhonov commented: """ Hi @sumit-bose, please take a look at another attempt. To address your second remark I have introduced `sss_printable_keytab_name()` helper. If its impl is ok then I think we should make use of it instead of `KEYTAB_CLEAN_NAME` in ldap/krb5_child as well (but I think as another PR since it goes of scope) Btw, during testing I have discovered that do-while loop in `select_principal_from_keytab()` is written in a such a way that it may try (primary=null)&(realm=null) at the last step. How do you think, is it an intent? I guess it is an error. """ See the full comment at https://github.com/SSSD/sssd/pull/883#issuecomment-541148774
_______________________________________________ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
