URL: https://github.com/SSSD/sssd/pull/902
Title: #902: Added ERROR and PRINT macros to the tools
mzidek-rh commented:
"""
@alexal I found one more indentation nitpick, I did not notice this the first
time. The string below should be aligned with the string above:
```
diff --git a/src/tools/sssctl/sssctl_config.c b/src/tools/sssctl/sssctl_config.c
index 7b324db21..4852e2216 100644
--- a/src/tools/sssctl/sssctl_config.c
+++ b/src/tools/sssctl/sssctl_config.c
@@ -79,7 +79,7 @@ errno_t sssctl_config_check(struct sss_cmdline *cmdline,
ret = sss_ini_config_access_check(init_data);
if (ret != EOK) {
PRINT("File ownership and permissions check failed. "
- "Expected root:root and 0600.\n");
+ "Expected root:root and 0600.\n");
ret = EPERM;
goto done;
}
```
Other than that it looks good.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/902#issuecomment-542884702
_______________________________________________
sssd-devel mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedorahosted.org/archives/list/[email protected]
