URL: https://github.com/SSSD/sssd/pull/938 Title: #938: Don't use tabs for indentation
mzidek-rh commented: """ Hi @miztake , I would prefer not to merge this change. I am worried about the backporting issues that may arise from this. We fix indentation issues when we already touch the badly formatted part of code for some other reason, for example if we touch a function and notice some lines are not indented properly, so we fix that as well (in the same or in separate patch), because the overall scope of change does not change too much. But fixing all indentation issues in the codebase touches too many places and complicates backporting. Citing the coding guidelines: "All new code should adhere to these standards but please do not go back and make wholesale formatting changes to the old code. It just confuses things and is generally a waste of time." ( see https://docs.pagure.org/SSSD.sssd/developers/coding_style.html ) I do see value in this patch, but it is still a NACK from me. Anyway, thank you for your efforts. """ See the full comment at https://github.com/SSSD/sssd/pull/938#issuecomment-553820338
_______________________________________________ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
