URL: https://github.com/SSSD/sssd/pull/905 Title: #905: Don't ignore host entries in Group Policy security filters
pbrezina commented: """ Thank you for these patches. I have just few nitpicks: We have a convention of prefixing output variables with underscore, i.e. `size_t *_num_hosts`. Can you amend new sysdb functions to this style please? Also there is a bad indentation of `sysdb_search_computer` parameters. More important: can you add some rationale to the first commit message so it is clear why this change is done and what are the benefits? The last commit contains few `FIXMEs`. Can you address them as well? Or what are the consequences if they are not addressed? Thank you. """ See the full comment at https://github.com/SSSD/sssd/pull/905#issuecomment-559034141
_______________________________________________ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
