URL: https://github.com/SSSD/sssd/pull/947 Title: #947: tests: fix race conditions in integration tests
pbrezina commented: """ > I see this as a bug in the SSSD (libnss_files.so doesn't have such an issue). > And I think hiding this bug in a test is not the best way to deal with it. Its not a bug, it is a feature because SSSD is notified about the changes through inotify instead of reading the file. It should be remmedied - yes. File a ticket for it. When changed, new tests for this change will be written. But currently, it is a feature that tests need to account for. > Probably I am wrong and this behavior of SSSD:files_provider can be justified. > But I am not sure if PR comments is proper place to do such justification. > > From my point of view it would be preferable to: > > 1. mark parts of the test that fail due to described race as "expected to > fail" (to make CI usable) That means tests are unstable, unusable and we may as well remove them because they do not test anything. > 2. open issue against files_provider, triage it properly See above. > 3. depending on the results of (2) either wait for fix or allow extended > timeout in the test (this patch) We are testing current code, not future changes. """ See the full comment at https://github.com/SSSD/sssd/pull/947#issuecomment-561290393
_______________________________________________ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
