URL: https://github.com/SSSD/sssd/pull/992
Title: #992: This changes the default ldap_group_name attribute to 
sAMAccountName

pbrezina commented:
"""
```diff
diff --git a/src/tests/intg/data/ad_schema.ldif 
b/src/tests/intg/data/ad_schema.ldif
index 1e4b777a2..6ae533a55 100644
--- a/src/tests/intg/data/ad_schema.ldif
+++ b/src/tests/intg/data/ad_schema.ldif
@@ -3,7 +3,7 @@ objectClass: olcSchemaConfig
 cn: ad
 structuralObjectClass: olcSchemaConfig
 olcAttributeTypes: {0}( 1.2.840.113556.1.4.750 NAME 'groupType' SYNTAX 
'1.3.6.1.4.1.1466.115.121.1.27' SINGLE-VALUE )
-olcAttributeTypes: {1}( 1.2.840.113556.1.4.221 NAME 'sAMAccountName' EQUALITY 
caseExactMatch SYNTAX '1.3.6.1.4.1.1466.115.121.1.15' SINGLE-VALUE )
+olcAttributeTypes: {1}( 1.2.840.113556.1.4.221 NAME 'sAMAccountName' EQUALITY 
caseIgnoreMatch SYNTAX '1.3.6.1.4.1.1466.115.121.1.15' SINGLE-VALUE )
 olcAttributeTypes: {2}( 1.2.840.113556.1.4.35 NAME 'employeeID' EQUALITY 
integerMatch SYNTAX '1.3.6.1.4.1.1466.115.121.1.27' SINGLE-VALUE )
 olcAttributeTypes: {3}( 1.2.840.113556.1.2.1 NAME 'instanceType' EQUALITY 
integerMatch SYNTAX '1.3.6.1.4.1.1466.115.121.1.27' SINGLE-VALUE )
 olcAttributeTypes: {4}( 1.2.840.113556.1.4.782 NAME 'objectCategory' EQUALITY 
caseExactMatch SYNTAX '1.3.6.1.4.1.1466.115.121.1.15' SINGLE-VALUE )
```

Schema that is used for tests defines `sAMAccountName` as case sensitive. 
Switching it to be case insensitive fix the tests and it is correct based on MS 
documentation: 
[here](https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-ada3/56d7e9e4-1505-4d9a-b968-3bf0d6b92809?redirectedfrom=MSDN)
 and 
[here](https://docs.microsoft.com/cs-cz/windows/win32/adschema/s-string-unicode?redirectedfrom=MSDN).

Can you amend the patch please?
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/992#issuecomment-607188333
_______________________________________________
sssd-devel mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/[email protected]

Reply via email to