URL: https://github.com/SSSD/sssd/pull/5305
Author: mrniranjan
 Title: #5305: pytest/testlib: Execute pk12util command to create ca.p12
Action: opened

PR body:
"""
execute the pk12util command to create ca.p12 file
Minor fix: return variable should be out of the for loop scope

Signed-off-by: Niranjan M.R <[email protected]>
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5305/head:pr5305
git checkout pr5305
From ad6e314eed6242df165f84ef78499d59049226f7 Mon Sep 17 00:00:00 2001
From: "Niranjan M.R" <[email protected]>
Date: Thu, 3 Sep 2020 16:10:17 +0530
Subject: [PATCH] pytest/testlib: Execute pk12util command to create ca.p12

execute the pk12util command to create ca.p12 file
Minor fix: return variable should be out of the for loop scope

Signed-off-by: Niranjan M.R <[email protected]>
---
 src/tests/python/sssd/testlib/common/utils.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/tests/python/sssd/testlib/common/utils.py b/src/tests/python/sssd/testlib/common/utils.py
index 4dabb787c6..2a26dd4547 100644
--- a/src/tests/python/sssd/testlib/common/utils.py
+++ b/src/tests/python/sssd/testlib/common/utils.py
@@ -833,6 +833,7 @@ def createselfsignedcerts(self,
                                 ' -k %s -w %s' % (nss_dir, ca_p12_path,
                                                   canickname, self.pwdfilepath,
                                                   self.pwdfilepath)
+                _, _, return_code = self.execute(shlex.split(export_ca_p12))
                 server_pkcs12_file = '%s-%s' % (server, 'server.p12')
                 server_p12 = os.path.join(nss_dir, server_pkcs12_file)
                 export_svr_p12 = 'pk12util -d %s -o %s -n %s'\
@@ -841,7 +842,7 @@ def createselfsignedcerts(self,
                                                    self.pwdfilepath,
                                                    self.pwdfilepath)
                 _, _, return_code = self.execute(shlex.split(export_svr_p12))
-                return nss_dir
+        return nss_dir
 
 
 class ADOperations(object):
_______________________________________________
sssd-devel mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/[email protected]

Reply via email to