URL: https://github.com/SSSD/sssd/pull/5226 Title: #5226: python/pysss_nss_idmap: check return from functions
ikerexxe commented: """ > Thanks for the update. Please see comment inline. Yes, it makes sense. I'll change it. > > Btw, wouldn't it make sense to include `Py_DECREF(module);` (actually better > `Py_XDECREF`) into `MODINITERROR`? It makes sense to include `Py_XDECREF(module)` in another macro called `FREEMOD_AND_RETURN`(?) and call it from the changes I've made. I wouldn't like messing with `MODINITERROR` as it's already called from other places where it doesn't make to decrease module. An example: https://github.com/SSSD/sssd/blob/fbc7082149ccc6ee4fe077480a5d692a86e75c79/src/util/sss_python.h#L39 What do you think? """ See the full comment at https://github.com/SSSD/sssd/pull/5226#issuecomment-688916091
_______________________________________________ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
