URL: https://github.com/SSSD/sssd/pull/5453 Author: pbrezina Title: #5453: gssapi: default pam_gssapi_services to NULL in domain section Action: opened
PR body: """ We need to distinguish when the option is not set in domain section and when it is is explicitly disabled. Now if it is not set, domain->gssapi_services is NULL and we'll use value from the pam section. Without this change, the value in the pam section is ignored. """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5453/head:pr5453 git checkout pr5453
From 1e15e80d79bdc0ba34d8b238562e3baa890763ad Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= <[email protected]> Date: Mon, 11 Jan 2021 13:11:39 +0100 Subject: [PATCH] gssapi: default pam_gssapi_services to NULL in domain section We need to distinguish when the option is not set in domain section and when it is is explicitly disabled. Now if it is not set, domain->gssapi_services is NULL and we'll use value from the pam section. Without this change, the value in the pam section is ignored. --- src/confdb/confdb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/confdb/confdb.c b/src/confdb/confdb.c index 2881ce5da7..befcfff2db 100644 --- a/src/confdb/confdb.c +++ b/src/confdb/confdb.c @@ -1582,7 +1582,7 @@ static int confdb_get_domain_internal(struct confdb_ctx *cdb, } tmp = ldb_msg_find_attr_as_string(res->msgs[0], CONFDB_PAM_GSSAPI_SERVICES, - "-"); + NULL); if (tmp != NULL) { ret = split_on_separator(domain, tmp, ',', true, true, &domain->gssapi_services, NULL);
_______________________________________________ sssd-devel mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/[email protected]
