URL: https://github.com/SSSD/sssd/pull/5570 Title: #5570: LDAP: make connection log levels consistent
alexey-tikhonov commented: """ > I have last question - in old log for `sdap_ldap_connect_callback_add` there > was an `LDAP` keyword. In new log it has been removed. I removed "LDAP" because it doesn't add any information and to make it consistent with other messages. > If it is not something which QA / client may be looking for in logs? Tests that run in upstream PR CI didn't fail. > Maybe instead we should have `LDAP` keyword in all those log lines? This is symmetric: if any test greps for a particular line addition of "LDAP" equally likely can cause issues. To remove this word in a single place is easier (lesser patch) than to add in several places. """ See the full comment at https://github.com/SSSD/sssd/pull/5570#issuecomment-827504462
_______________________________________________ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
