URL: https://github.com/SSSD/sssd/pull/5646 Author: ikerexxe Title: #5646: responder: fix covscan issues Action: opened
PR body: """ Fix two covscan issues that I accidentally included in commit f890fc4b592767f3f0b2bd5515cbd9516505ebe9. Error: FORWARD_NULL (CWE-476): [#def60] sssd-2.4.0/src/responder/common/responder_common.c:1009: var_compare_op: Comparing "rctx->sock_name" to null implies that "rctx->sock_name" might be null. sssd-2.4.0/src/responder/common/responder_common.c:1039: var_deref_model: Passing null pointer "rctx->sock_name" to "strlen", which dereferences it. Error: CLANG_WARNING: [#def61] sssd-2.4.0/src/responder/common/responder_common.c:1039:64: warning[core.NonNullParamChecker]: Null pointer passed to 1st parameter expecting 'nonnull' Resolves: https://github.com/SSSD/sssd/issues/5638 """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5646/head:pr5646 git checkout pr5646
From 5645ebc03043efdbf6f927ac1527654e6d571cea Mon Sep 17 00:00:00 2001 From: Iker Pedrosa <[email protected]> Date: Fri, 21 May 2021 17:27:08 +0200 Subject: [PATCH] responder: fix covscan issues Fix two covscan issues that I accidentally included in commit f890fc4b592767f3f0b2bd5515cbd9516505ebe9. Error: FORWARD_NULL (CWE-476): [#def60] sssd-2.4.0/src/responder/common/responder_common.c:1009: var_compare_op: Comparing "rctx->sock_name" to null implies that "rctx->sock_name" might be null. sssd-2.4.0/src/responder/common/responder_common.c:1039: var_deref_model: Passing null pointer "rctx->sock_name" to "strlen", which dereferences it. Error: CLANG_WARNING: [#def61] sssd-2.4.0/src/responder/common/responder_common.c:1039:64: warning[core.NonNullParamChecker]: Null pointer passed to 1st parameter expecting 'nonnull' Resolves: https://github.com/SSSD/sssd/issues/5638 --- src/responder/common/responder_common.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/responder/common/responder_common.c b/src/responder/common/responder_common.c index 2031f93d12..7fbf373ada 100644 --- a/src/responder/common/responder_common.c +++ b/src/responder/common/responder_common.c @@ -1041,7 +1041,8 @@ int activate_unix_sockets(struct resp_ctx *rctx, ret = getsockname(rctx->lfd, (struct sockaddr *) &sockaddr, &sockaddr_len); if (ret == EOK) { - if (memcmp(rctx->sock_name, sockaddr.sun_path, strlen(rctx->sock_name)) != 0) { + if (rctx->sock_name && + memcmp(rctx->sock_name, sockaddr.sun_path, strlen(rctx->sock_name)) != 0) { DEBUG(SSSDBG_CONF_SETTINGS, "Warning: socket path defined in systemd unit (%s) and sssd.conf (%s) don't match\n", sockaddr.sun_path, rctx->sock_name);
_______________________________________________ sssd-devel mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/[email protected] Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
