URL: https://github.com/SSSD/sssd/pull/5600 Author: DeepakDas7 Title: #5600: [WIP] SSSD Log: log_bad_address_msg_modification Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5600/head:pr5600 git checkout pr5600
From 049f9da4d8f4194acef11ca816c5f147e2ec443d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= <[email protected]> Date: Tue, 8 Jun 2021 13:37:23 +0200 Subject: [PATCH 1/2] SSSD Log: log_bad_address_msg_modification Improve Log Containing Bad Address string Resolves: https://github.com/SSSD/sssd/issues/5577 --- src/providers/ad/ad_gpo.c | 4 ++-- src/providers/data_provider_fo.c | 4 ++++ src/providers/ldap/sdap_async_connection.c | 11 +++++++++-- version.m4 | 2 +- 4 files changed, 16 insertions(+), 5 deletions(-) diff --git a/src/providers/ad/ad_gpo.c b/src/providers/ad/ad_gpo.c index 4ef6a7219c..b4bb88c434 100644 --- a/src/providers/ad/ad_gpo.c +++ b/src/providers/ad/ad_gpo.c @@ -2448,8 +2448,8 @@ ad_gpo_process_gpo_done(struct tevent_req *subreq) if (ret != EOK && ret != ENOENT) { DEBUG(SSSDBG_OP_FAILURE, - "Unable to get GPO list: [%d](%s)\n", - ret, sss_strerror(ret)); + "Unable to get GPO list from server %s: [%d](%s)\n", + state->ad_hostname, ret, sss_strerror(ret)); goto done; } else if (ret == ENOENT) { DEBUG(SSSDBG_TRACE_FUNC, diff --git a/src/providers/data_provider_fo.c b/src/providers/data_provider_fo.c index cf8e3feadf..4359285866 100644 --- a/src/providers/data_provider_fo.c +++ b/src/providers/data_provider_fo.c @@ -578,6 +578,10 @@ static void be_resolve_server_done(struct tevent_req *subreq) if (ret == ENOENT) { DEBUG(SSSDBG_TRACE_LIBS, "Server resolution failed: [%d]: All servers down\n", ret); + } else if (ret == EFAULT || ret == EIO || ret == EPERM) { + DEBUG(SSSDBG_TRACE_LIBS, + "Server [%s] resolution failed: [%d]: %s\n", + fo_get_server_name(state->srv), ret, sss_strerror(ret)); } else { DEBUG(SSSDBG_TRACE_LIBS, "Server resolution failed: [%d]: %s\n", ret, sss_strerror(ret)); diff --git a/src/providers/ldap/sdap_async_connection.c b/src/providers/ldap/sdap_async_connection.c index 8a3b630374..f68f8b74b4 100644 --- a/src/providers/ldap/sdap_async_connection.c +++ b/src/providers/ldap/sdap_async_connection.c @@ -1276,8 +1276,15 @@ static void sdap_kinit_done(struct tevent_req *subreq) } - DEBUG(SSSDBG_CONF_SETTINGS, - "Could not get TGT: %d [%s]\n", result, sss_strerror(result)); + if (result == EFAULT || result == EIO || result == EPERM) { + DEBUG(SSSDBG_CONF_SETTINGS, + "Could not get TGT from server %s: %d [%s]\n", + fo_get_server_name(state->kdc_srv), result, sss_strerror(result)); + } else { + DEBUG(SSSDBG_CONF_SETTINGS, + "Could not get TGT: %d [%s]\n", result, sss_strerror(result)); + } + tevent_req_error(req, ERR_AUTH_FAILED); } diff --git a/version.m4 b/version.m4 index 2d5494d39e..f11db062f9 100644 --- a/version.m4 +++ b/version.m4 @@ -1,5 +1,5 @@ # Primary version number -m4_define([VERSION_NUMBER], [2.5.1]) +m4_define([VERSION_NUMBER], [2.5.2]) # If the PRERELEASE_VERSION_NUMBER is set, we'll append # it to the release tag when creating an RPM or SRPM From 424173925b200b66ed09b0a35d48039a0e0af6e6 Mon Sep 17 00:00:00 2001 From: DeepakDas7 <[email protected]> Date: Wed, 9 Jun 2021 15:07:29 +0530 Subject: [PATCH 2/2] Delete version.m4 --- version.m4 | 12 ------------ 1 file changed, 12 deletions(-) delete mode 100644 version.m4 diff --git a/version.m4 b/version.m4 deleted file mode 100644 index f11db062f9..0000000000 --- a/version.m4 +++ /dev/null @@ -1,12 +0,0 @@ -# Primary version number -m4_define([VERSION_NUMBER], [2.5.2]) - -# If the PRERELEASE_VERSION_NUMBER is set, we'll append -# it to the release tag when creating an RPM or SRPM -# This is intended for build systems to create snapshot -# RPMs. The format should be something like: -# .20090915gitf1bcde7 -# and would result in an SRPM looking like: -# sssd-0.5.0-0.20090915gitf1bcde7.fc11.src.rpm -m4_define([PRERELEASE_VERSION_NUMBER], []) -
_______________________________________________ sssd-devel mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/[email protected] Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
