URL: https://github.com/SSSD/sssd/pull/5600 Author: DeepakDas7 Title: #5600: SSSD Log: log_bad_address_msg_modification Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5600/head:pr5600 git checkout pr5600
From c68ad189899dc6ef6e1396225ea8d9160a4be185 Mon Sep 17 00:00:00 2001 From: Deepak Das <[email protected]> Date: Sat, 19 Jun 2021 23:24:03 +0530 Subject: [PATCH] SSSD Log: log_bad_address_msg_mod Improve Log Containing Bad Address string Resolves: https://github.com/SSSD/sssd/issues/5577 --- src/providers/ad/ad_gpo.c | 4 ++-- src/providers/data_provider_fo.c | 6 ++++++ src/providers/ldap/sdap_async_connection.c | 12 +++++++++--- 3 files changed, 17 insertions(+), 5 deletions(-) diff --git a/src/providers/ad/ad_gpo.c b/src/providers/ad/ad_gpo.c index b2df3e998b..219f398491 100644 --- a/src/providers/ad/ad_gpo.c +++ b/src/providers/ad/ad_gpo.c @@ -2448,8 +2448,8 @@ ad_gpo_process_gpo_done(struct tevent_req *subreq) if (ret != EOK && ret != ENOENT) { DEBUG(SSSDBG_OP_FAILURE, - "Unable to get GPO list: [%d](%s)\n", - ret, sss_strerror(ret)); + "Unable to get GPO list from server %s: [%d](%s)\n", + state->ad_hostname ? state->ad_hostname : "NULL", ret, sss_strerror(ret)); goto done; } else if (ret == ENOENT) { DEBUG(SSSDBG_TRACE_FUNC, diff --git a/src/providers/data_provider_fo.c b/src/providers/data_provider_fo.c index cf8e3feadf..ff77ede792 100644 --- a/src/providers/data_provider_fo.c +++ b/src/providers/data_provider_fo.c @@ -578,6 +578,12 @@ static void be_resolve_server_done(struct tevent_req *subreq) if (ret == ENOENT) { DEBUG(SSSDBG_TRACE_LIBS, "Server resolution failed: [%d]: All servers down\n", ret); + } else if (ret == EFAULT || ret == EIO || ret == EPERM) { + DEBUG(SSSDBG_TRACE_LIBS, + "Server [%s] resolution failed: [%d]: %s\n", + state->srv ? fo_get_server_name(state->srv) : "NULL", + ret, sss_strerror(ret)); + } else { DEBUG(SSSDBG_TRACE_LIBS, "Server resolution failed: [%d]: %s\n", ret, sss_strerror(ret)); diff --git a/src/providers/ldap/sdap_async_connection.c b/src/providers/ldap/sdap_async_connection.c index 8a3b630374..bd91669f02 100644 --- a/src/providers/ldap/sdap_async_connection.c +++ b/src/providers/ldap/sdap_async_connection.c @@ -1275,9 +1275,15 @@ static void sdap_kinit_done(struct tevent_req *subreq) } } - - DEBUG(SSSDBG_CONF_SETTINGS, - "Could not get TGT: %d [%s]\n", result, sss_strerror(result)); + if (result == EFAULT || result == EIO || result == EPERM) { + DEBUG(SSSDBG_CONF_SETTINGS, + "Could not get TGT from server %s: %d [%s]\n", + state->kdc_srv ? fo_get_server_name(state->kdc_srv) : "NULL", + result, sss_strerror(result)); + } else { + DEBUG(SSSDBG_CONF_SETTINGS, + "Could not get TGT: %d [%s]\n", result, sss_strerror(result)); + } tevent_req_error(req, ERR_AUTH_FAILED); }
_______________________________________________ sssd-devel mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/[email protected] Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
