URL: https://github.com/SSSD/sssd/pull/5709 Title: #5709: General: Hardeninig getenv() usage
elkoniu commented: """ Hi @mzidek-gh , thank you for taking a look at this. I like your idea (it could be used across all SSSD code) but I have a few comments to it. Such function will require 3rd parameter - talloc context to which allocated memory needs to be attached. I check the code and in many places where `getenv()` is called - talloc is not used at all. Moreover `getenv()` call is problematic only when we are pushing its result to sub functions or down the pipe. In most places result is "consumed" in the same function and is not used anymore. """ See the full comment at https://github.com/SSSD/sssd/pull/5709#issuecomment-884074405
_______________________________________________ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
