URL: https://github.com/SSSD/sssd/pull/5709 Title: #5709: General: Hardeninig getenv() usage
pbrezina commented: """ > Overall LGTM, but there are some extra newlines and a lot of Yoda condition. > @pbrezina what is the current team position on Yoda conditions? I remember we > did not want them, but I do not see them mentioned in the coding guidelines: > https://sssd.io/contrib/coding-style.html It's not banned explicitly, but we don't use it. ret == EOK is the way to go. Saying that, I hope the Force will stay with me. """ See the full comment at https://github.com/SSSD/sssd/pull/5709#issuecomment-888169865
_______________________________________________ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
