URL: https://github.com/SSSD/sssd/pull/5712
Title: #5712: Health and Support Analyzer - Add request log parsing utility

justin-stephenson commented:
"""
> This looks better, thanks. I would certainly like to get it reviewed by 
> python developers. At least, the two Reader classes should use inheritance.
> 
> Perhaps, we can avoid using @PYTHON_BIN_PATH@ and configure time option and 
> just sed the shebang in spec file after install? I'm not sure if this is a 
> good idea, please reach to python developers for advice. But it would make 
> testing easier.
> 

Okay I will ask a python developer to review this.

> I think it would be also good to print uid of the user who started the 
> request (client uid) in the `list` command. It is not yet available in the 
> logs but can be added from `cli_creds_get_uid(cli_ctx->creds)`

Done. list output now looks like
~~~
2021-10-01 15:00:40: [uid 0] CID #1: id
2021-10-01 15:01:01: [uid 0] CID #2: /usr/sbin/crond
2021-10-01 15:04:45: [uid 1000] CID #3: id
2021-10-01 15:04:47: [uid 0] CID #4: sudo
2021-10-01 15:04:47: [uid 0] CID #5: su
~~~

"""

See the full comment at 
https://github.com/SSSD/sssd/pull/5712#issuecomment-932323013
_______________________________________________
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to