URL: https://github.com/SSSD/sssd/pull/5827 Title: #5827: A number of fixes around `strto*()` usage
alexey-tikhonov commented: """ > I found call for `strtoul()` in one more place: > > ``` > src/providers/ldap/sdap_sudo_shared.c > > 194: strtoul(srv_opts->max_sudo_value, &timezone, 10); > > 204: usn_number = strtoul(usn, &timezone, 10); > ``` > > I think in the 2nd case evaluation against `> UINT32_MAX` is missing. Why? https://ldapwiki.com/wiki/Update%20Sequence%20Number says `Update Sequence Number (USN) is a 64-bit number `. """ See the full comment at https://github.com/SSSD/sssd/pull/5827#issuecomment-946116907
_______________________________________________ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
