URL: https://github.com/SSSD/sssd/pull/5855 Title: #5855: CKM_RSA_PKCS support.
sumit-bose commented: """ Hi, thank you for the patch. Code-wise I'm fine and my test were successful as well. While talking about test, I think it would be good to have tests as well. SoftHSM2 allows to define the available mechanism with the `slots.mechanisms` option. I tested the patch by adding `slots.mechanisms = CKM_RSA_PKCS` to `softhsm2_one.conf` and run `pam-srv-tests`. I wonder if you can add some tests with different mechanisms (yes, I know, I should have added them when I added the additional mechanisms) or if you prefer if this should be moved to a different PR? bye, Sumit """ See the full comment at https://github.com/SSSD/sssd/pull/5855#issuecomment-960608478
_______________________________________________ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
