URL: https://github.com/SSSD/sssd/pull/5916
Author: pbrezina
Title: #5916: intg: remove unused is_secrets_socket()
Action: opened
PR body:
"""
Use of this function was removed in:
10069b1d39e671b7502c5211883c94ceaa91aebb
```
sssd/build/../src/tests/intg/getsockopt_wrapper.c:31:13: error:
‘is_secrets_socket’ defined but not used [-Werror=unused-function]
31 | static bool is_secrets_socket(int fd)
```
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5916/head:pr5916
git checkout pr5916
From 9ec751c5c8241bdbb782509bcc661cf9abccca10 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pavel=20B=C5=99ezina?= <pbrez...@redhat.com>
Date: Mon, 13 Dec 2021 11:35:19 +0100
Subject: [PATCH] intg: remove unused is_secrets_socket()
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Use of this function was removed in:
10069b1d39e671b7502c5211883c94ceaa91aebb
```
sssd/build/../src/tests/intg/getsockopt_wrapper.c:31:13: error: ‘is_secrets_socket’ defined but not used [-Werror=unused-function]
31 | static bool is_secrets_socket(int fd)
```
---
src/tests/intg/getsockopt_wrapper.c | 17 -----------------
1 file changed, 17 deletions(-)
diff --git a/src/tests/intg/getsockopt_wrapper.c b/src/tests/intg/getsockopt_wrapper.c
index 0559393b3d..725693cc8b 100644
--- a/src/tests/intg/getsockopt_wrapper.c
+++ b/src/tests/intg/getsockopt_wrapper.c
@@ -28,23 +28,6 @@ static bool is_dbus_socket(int fd)
return NULL != strstr(unix_socket->sun_path, "system_bus_socket");
}
-static bool is_secrets_socket(int fd)
-{
- int ret;
- struct sockaddr_storage addr = { 0 };
- socklen_t addrlen = sizeof(addr);
- struct sockaddr_un *unix_socket;
-
- ret = getsockname(fd, (struct sockaddr *)&addr, &addrlen);
- if (ret != 0) return false;
-
- if (addr.ss_family != AF_UNIX) return false;
-
- unix_socket = (struct sockaddr_un *)&addr;
-
- return NULL != strstr(unix_socket->sun_path, "secrets.socket");
-}
-
static bool peer_is_private_pam(int fd)
{
int ret;
_______________________________________________
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
