We need to drop the mutex and do a dev_put, so set an error code and break like the other paths, instead of returning directly.
Cc: [email protected] Signed-off-by: Nelson Elhage <[email protected]> --- net/econet/af_econet.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/net/econet/af_econet.c b/net/econet/af_econet.c index 13992e1..f180371 100644 --- a/net/econet/af_econet.c +++ b/net/econet/af_econet.c @@ -661,8 +661,10 @@ static int ec_dev_ioctl(struct socket *sock, unsigned int cmd, void __user *arg) err = 0; switch (cmd) { case SIOCSIFADDR: - if (!capable(CAP_NET_ADMIN)) - return -EPERM; + if (!capable(CAP_NET_ADMIN)) { + err = -EPERM; + break; + } edev = dev->ec_ptr; if (edev == NULL) { -- 1.7.1.31.g6297e _______________________________________________ stable mailing list [email protected] http://linux.kernel.org/mailman/listinfo/stable
