On Tue, Nov 23, 2010 at 01:38:17PM +0100, Johan Hovold wrote:
> On Sat, Oct 30, 2010 at 1:34 AM,  <[email protected]> wrote:
> >
> > This is a note to let you know that I've just added the patch titled
> >
> >    USB: ftdi_sio: revert "USB: ftdi_sio: fix DTR/RTS line modes"
> >
> > to the 2.6.35-stable tree which can be found at:
> 
> [...]
> 
> > From 677aeafe19e88c282af74564048243ccabb1c590 Mon Sep 17 00:00:00 2001
> > From: Johan Hovold <[email protected]>
> > Date: Sun, 12 Sep 2010 16:31:45 +0200
> > Subject: USB: ftdi_sio: revert "USB: ftdi_sio: fix DTR/RTS line modes"
> >
> > From: Johan Hovold <[email protected]>
> >
> > commit 677aeafe19e88c282af74564048243ccabb1c590 upstream.
> >
> > This reverts commit 6a1a82df91fa0eb1cc76069a9efe5714d087eccd.
> >
> > RTS and DTR should not be modified based on CRTSCTS when calling
> > set_termios.
> >
> > Modem control lines are raised at port open by the tty layer and should stay
> > raised regardless of whether hardware flow control is enabled or not.
> >
> > This is in conformance with the way serial ports work today and many
> > applications depend on this behaviour to be able to talk to hardware
> > implementing hardware flow control (without the applications actually using
> > it).
> >
> > Hardware which expects different behaviour on these lines can always
> > use TIOCMSET/TIOCMBI[SC] after port open to change them.
> >
> > Reported-by: Daniel Mack <[email protected]>
> > Reported-by: Dave Mielke <[email protected]>
> > Signed-off-by: Johan Hovold <[email protected]>
> > Signed-off-by: Greg Kroah-Hartman <[email protected]>
> 
> Sorry for not noticing sooner, but shouldn't this one be added to the
> 2.6.32 stable tree as well?

Yes it should, I've now queued it up there, thanks for pointing it out.

greg k-h

_______________________________________________
stable mailing list
[email protected]
http://linux.kernel.org/mailman/listinfo/stable

Reply via email to