On 12/09/2010 03:17 AM, Sheng Yang wrote:
> > if (!is_long_mode(vcpu)&& is_pae(vcpu)) { > > > > load_pdptrs(vcpu, vcpu->arch.walk_mmu, vcpu->arch.cr3); > > mmu_reset_needed = 1; > > We really should use kvm_set_crX() here.Yeah, I suppose we use ops->set_cr4() here because we don't need to all kinds of check and operation for the value(which should already be done by other S/R code), so I just add update_cpuid() here.
IIRC the reason is that there are ordering constraints for kvm_set_crX (and kvm_set_efer). We should do a kvm_set_crs() which sets them all at once.
-- error compiling committee.c: too many arguments to function _______________________________________________ stable mailing list [email protected] http://linux.kernel.org/mailman/listinfo/stable
