commit: 4ef9e11d6867f88951e30db910fa015300e31871 From: Hillf Danton <[email protected]> Date: Wed, 29 Dec 2010 21:55:28 +0800 Subject: [PATCH] fix freeing user_struct in user cache
When racing on adding into user cache, the new allocated from mm slab is freed without putting user namespace. Since the user namespace is already operated by getting, putting has to be issued. Signed-off-by: Hillf Danton <[email protected]> Acked-by: Serge Hallyn <[email protected]> Cc: [email protected] Signed-off-by: Linus Torvalds <[email protected]> --- kernel/user.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/kernel/user.c b/kernel/user.c index 2c7d8d5..5c598ca 100644 --- a/kernel/user.c +++ b/kernel/user.c @@ -158,6 +158,7 @@ struct user_struct *alloc_uid(struct user_namespace *ns, uid_t uid) spin_lock_irq(&uidhash_lock); up = uid_hash_find(uid, hashent); if (up) { + put_user_ns(ns); key_put(new->uid_keyring); key_put(new->session_keyring); kmem_cache_free(uid_cachep, new); _______________________________________________ stable mailing list [email protected] http://linux.kernel.org/mailman/listinfo/stable
