This is a note to let you know that I've just added the patch titled
libata-sff: fix HSM_ST_ERR handling in __ata_sff_port_intr()
to the 2.6.36-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
libata-sff-fix-hsm_st_err-handling-in-__ata_sff_port_intr.patch
and it can be found in the queue-2.6.36 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <[email protected]> know about it.
>From 687a993339c4f3a63654746230da3aab8bbdbffd Mon Sep 17 00:00:00 2001
From: Tejun Heo <[email protected]>
Date: Fri, 3 Dec 2010 15:19:13 +0100
Subject: libata-sff: fix HSM_ST_ERR handling in __ata_sff_port_intr()
From: Tejun Heo <[email protected]>
commit 687a993339c4f3a63654746230da3aab8bbdbffd upstream.
While separating out BMDMA irq handler from SFF, commit c3b28894
(libata-sff: separate out BMDMA irq handler) incorrectly made
__ata_sff_port_intr() consider an IRQ to be an idle one if the host
state was transitioned to HSM_ST_ERR by ata_bmdma_port_intr().
This makes BMDMA drivers ignore IRQs reporting host bus error which
leads to timeouts instead of triggering EH immediately. Fix it by
making __ata_sff_port_intr() consider the IRQ to be an idle one iff
the state is HSM_ST_IDLE. This is equivalent to adding HSM_ST_ERR to
the "break"ing case but less error-prone.
Signed-off-by: Tejun Heo <[email protected]>
Reported-by: Antonio Toma <[email protected]>
Signed-off-by: Jeff Garzik <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
---
drivers/ata/libata-sff.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
--- a/drivers/ata/libata-sff.c
+++ b/drivers/ata/libata-sff.c
@@ -1532,11 +1532,10 @@ static unsigned int __ata_sff_port_intr(
if (!(qc->dev->flags & ATA_DFLAG_CDB_INTR))
return ata_sff_idle_irq(ap);
break;
- case HSM_ST:
- case HSM_ST_LAST:
- break;
- default:
+ case HSM_ST_IDLE:
return ata_sff_idle_irq(ap);
+ default:
+ break;
}
/* check main status, clearing INTRQ if needed */
Patches currently in stable-queue which might be from [email protected] are
queue-2.6.36/fuse-verify-ioctl-retries.patch
queue-2.6.36/libata-sff-fix-hsm_st_err-handling-in-__ata_sff_port_intr.patch
queue-2.6.36/fuse-fix-ioctl-when-server-is-32bit.patch
_______________________________________________
stable mailing list
[email protected]
http://linux.kernel.org/mailman/listinfo/stable
