The patch below is fine. Thanks. -Sathya
-----Original Message----- From: Greg KH [mailto:[email protected]] Sent: Thursday, January 06, 2011 5:53 AM To: [email protected]; [email protected] Cc: [email protected]; [email protected]; [email protected]; [email protected]; Perla, Sathya; Seetharaman, Subramanian; Bandi, Sarveshwar; Khaparde, Ajit; Joe Jin; David S. Miller Subject: [064/152] driver/net/benet: fix be_cmd_multicast_set() memcpy bug 2.6.36-stable review patch. If anyone has any objections, please let us know. ------------------ From: Joe Jin <[email protected]> [ Upstream commit 3fd40d0ceac9c234243730f4d7a6ffdb2fd3023a ] Regarding benet be_cmd_multicast_set() function, now using netdev_for_each_mc_addr() helper for mac address copy, but when copying to req->mac[] did not increase of the index. Cc: Sathya Perla <[email protected]> Cc: Subbu Seetharaman <[email protected]> Cc: Sarveshwar Bandi <[email protected]> Cc: Ajit Khaparde <[email protected]> Signed-off-by: Joe Jin <[email protected]> Signed-off-by: David S. Miller <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]> --- drivers/net/benet/be_cmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/benet/be_cmds.c +++ b/drivers/net/benet/be_cmds.c @@ -1179,7 +1179,7 @@ int be_cmd_multicast_set(struct be_adapt i = 0; netdev_for_each_mc_addr(ha, netdev) - memcpy(req->mac[i].byte, ha->addr, ETH_ALEN); + memcpy(req->mac[i++].byte, ha->addr, ETH_ALEN); } else { req->promiscuous = 1; } _______________________________________________ stable mailing list [email protected] http://linux.kernel.org/mailman/listinfo/stable
