commit: e7bf352fcd85c33b0805da891fc97fea8b5e996e From: roel kluin <[email protected]> Date: Mon, 3 Jan 2011 11:59:48 -0800 Subject: [PATCH] Staging: speakup: &&/|| confusion in silent_store()
Fix test: the branch is always taken. Signed-off-by: Roel Kluin <[email protected]> Cc: Andrew Morton <[email protected]> Cc: stable <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]> --- drivers/staging/speakup/kobjects.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c index 408bb9b..07a7f54 100644 --- a/drivers/staging/speakup/kobjects.c +++ b/drivers/staging/speakup/kobjects.c @@ -332,7 +332,7 @@ static ssize_t silent_store(struct kobject *kobj, struct kobj_attribute *attr, unsigned long flags; len = strlen(buf); - if (len > 0 || len < 3) { + if (len > 0 && len < 3) { ch = buf[0]; if (ch == '\n') ch = '0'; _______________________________________________ stable mailing list [email protected] http://linux.kernel.org/mailman/listinfo/stable
