This is a note to let you know that I've just added the patch titled

    mac80211: fix a crash in ieee80211_beacon_get_tim on change_interface

to the 2.6.36-stable tree which can be found at:
    
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     mac80211-fix-a-crash-in-ieee80211_beacon_get_tim-on-change_interface.patch
and it can be found in the queue-2.6.36 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <[email protected]> know about it.


>From eb3e554b4b3a56386ef5214dbe0e3935a350178b Mon Sep 17 00:00:00 2001
From: Felix Fietkau <[email protected]>
Date: Mon, 24 Jan 2011 19:28:49 +0100
Subject: mac80211: fix a crash in ieee80211_beacon_get_tim on change_interface

From: Felix Fietkau <[email protected]>

commit eb3e554b4b3a56386ef5214dbe0e3935a350178b upstream.

Some drivers (e.g. ath9k) do not always disable beacons when they're
supposed to. When an interface is changed using the change_interface op,
the mode specific sdata part is in an undefined state and trying to
get a beacon at this point can produce weird crashes.

To fix this, add a check for ieee80211_sdata_running before using
anything from the sdata.

Signed-off-by: Felix Fietkau <[email protected]>
Signed-off-by: John W. Linville <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

---
 net/mac80211/tx.c |    3 +++
 1 file changed, 3 insertions(+)

--- a/net/mac80211/tx.c
+++ b/net/mac80211/tx.c
@@ -2175,6 +2175,9 @@ struct sk_buff *ieee80211_beacon_get_tim
 
        sdata = vif_to_sdata(vif);
 
+       if (!ieee80211_sdata_running(sdata))
+               goto out;
+
        if (tim_offset)
                *tim_offset = 0;
        if (tim_length)


Patches currently in stable-queue which might be from [email protected] are

queue-2.6.36/ath9k-fix-bug-in-delimiter-padding-computation.patch
queue-2.6.36/mac80211-fix-initialization-of-skb-cb-in-ieee80211_subif_start_xmit.patch
queue-2.6.36/mac80211-fix-a-crash-in-ieee80211_beacon_get_tim-on-change_interface.patch

_______________________________________________
stable mailing list
[email protected]
http://linux.kernel.org/mailman/listinfo/stable

Reply via email to