Please consider the attached backported patch for 2.6.32.y and 2.6.35.y.
This comment
https://bugs.launchpad.net/ubuntu/hardy/+source/linux/+bug/585657/comments/18
indicates that it solves a bug. The kernel under test is based on 2.6.32.20.
rtg
--
Tim Gardner [email protected]
>From 0fefb96bf41a7c224db0600a481c6acb352230e3 Mon Sep 17 00:00:00 2001
From: Tim Gardner <[email protected]>
Date: Fri, 11 Feb 2011 11:04:37 -0700
Subject: [PATCH] NFS: fix the return value of nfs_file_fsync()
BugLink: http://bugs.launchpad.net/bugs/585657
Backport of 0702099bd86c33c2dcdbd3963433a61f3f503901
By the commit af7fa16 2010-08-03 NFS: Fix up the fsync code
close(2) became returning the non-zero value even if it went well.
nfs_file_fsync() should return 0 when "status" is positive.
Signed-off-by: J. R. Okajima <[email protected]>
Signed-off-by: Trond Myklebust <[email protected]>
Signed-off-by: Tim Gardner <[email protected]>
---
fs/nfs/file.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/nfs/file.c b/fs/nfs/file.c
index 6fed6cc..99545e2 100644
--- a/fs/nfs/file.c
+++ b/fs/nfs/file.c
@@ -220,7 +220,7 @@ static int nfs_do_fsync(struct nfs_open_context *ctx, struct inode *inode)
have_error |= test_bit(NFS_CONTEXT_ERROR_WRITE, &ctx->flags);
if (have_error)
ret = xchg(&ctx->error, 0);
- if (!ret)
+ if (!ret && status < 0)
ret = status;
return ret;
}
--
1.7.0.4
_______________________________________________
stable mailing list
[email protected]
http://linux.kernel.org/mailman/listinfo/stable
