This is the correct version of the patch to apply. ---------- Forwarded message ---------- Date: Tue, 15 Feb 2011 23:59:20 GMT From: Linux Kernel Mailing List <[email protected]> To: [email protected] Subject: pci: use security_capable() when checking capablities during config space read
Gitweb: http://git.kernel.org/linus/a628e7b87e100befac9702aa0c3b9848a7685e49 Commit: a628e7b87e100befac9702aa0c3b9848a7685e49 Parent: 795abaf1e4e188c4171e3cd3dbb11a9fcacaf505 Author: Chris Wright <[email protected]> AuthorDate: Mon Feb 14 17:21:49 2011 -0800 Committer: James Morris <[email protected]> CommitDate: Tue Feb 15 19:06:31 2011 +1100 pci: use security_capable() when checking capablities during config space read This reintroduces commit 47970b1b which was subsequently reverted as f00eaeea. The original change was broken and caused X startup failures and generally made privileged processes incapable of reading device dependent config space. The normal capable() interface returns true on success, but the LSM interface returns 0 on success. This thinko is now fixed in this patch, and has been confirmed to work properly. So, once again...Eric Paris noted that commit de139a3 ("pci: check caps from sysfs file open to read device dependent config space") caused the capability check to bypass security modules and potentially auditing. Rectify this by calling security_capable() when checking the open file's capabilities for config space reads. Reported-by: Eric Paris <[email protected]> Tested-by: Dave Young <[email protected]> Acked-by: James Morris <[email protected]> Cc: Dave Airlie <[email protected]> Cc: Alex Riesen <[email protected]> Cc: Sedat Dilek <[email protected]> Cc: Linus Torvalds <[email protected]> Signed-off-by: Chris Wright <[email protected]> Signed-off-by: James Morris <[email protected]> --- drivers/pci/pci-sysfs.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c index 8ecaac9..ea25e5b 100644 --- a/drivers/pci/pci-sysfs.c +++ b/drivers/pci/pci-sysfs.c @@ -23,6 +23,7 @@ #include <linux/mm.h> #include <linux/fs.h> #include <linux/capability.h> +#include <linux/security.h> #include <linux/pci-aspm.h> #include <linux/slab.h> #include "pci.h" @@ -368,7 +369,7 @@ pci_read_config(struct file *filp, struct kobject *kobj, u8 *data = (u8*) buf; /* Several chips lock up trying to read undefined config space */ - if (cap_raised(filp->f_cred->cap_effective, CAP_SYS_ADMIN)) { + if (security_capable(filp->f_cred, CAP_SYS_ADMIN) == 0) { size = dev->cfg_size; } else if (dev->hdr_type == PCI_HEADER_TYPE_CARDBUS) { size = 128; -- To unsubscribe from this list: send the line "unsubscribe git-commits-head" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html _______________________________________________ stable mailing list [email protected] http://linux.kernel.org/mailman/listinfo/stable
