This is a note to let you know that I've just added the patch titled
staging: brcm80211: remove assert to avoid panic since 2.6.37 kernel
to the 2.6.37-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
staging-brcm80211-remove-assert-to-avoid-panic-since-2.6.37-kernel.patch
and it can be found in the queue-2.6.37 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <[email protected]> know about it.
>From [email protected] Thu Feb 24 17:22:54 2011
From: "Arend van Spriel" <[email protected]>
Date: Thu, 24 Feb 2011 21:42:18 +0100
Subject: staging: brcm80211: remove assert to avoid panic since 2.6.37 kernel
To: [email protected]
Cc: [email protected], [email protected]
Message-ID: <[email protected]>
From: Arend van Spriel <[email protected]>
commit d062d44a8386c82c06e483f0c0d1124ba3cab2c8 upstream
The driver assumed it would receive skb packets from MAC80211 which
are not cloned. To guard this assumption an assert was placed in
the transmit routine. As of kernel 2.6.37 it turns out MAC80211 does
pass skb packets that are cloned. The assert is also not needed as
it does not lead to a failure state in our driver when the packet is
cloned. Therefore the assert can safely be removed.
> commit f8a0a781488ec7288d1049e5d2022850aa98f7b6
> Author: Felix Fietkau <[email protected]>
> Date: Sat Dec 18 19:30:50 2010 +0100
>
> mac80211: fix potentially redundant skb data copying
>
> When an skb is shared, it needs to be duplicated, along with its data
> If the skb does not have enough headroom, using skb_copy might cause t
> buffer to be copied twice (once by skb_copy and once by pskb_expand_he
> Fix this by using skb_clone initially and letting ieee80211_skb_resize
> out the rest.
>
> Signed-off-by: Felix Fietkau <[email protected]>
> Signed-off-by: John W. Linville <[email protected]>
>
Acked-by: Brett Rudley <[email protected]>
Signed-off-by: Arend van Spriel <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
---
drivers/staging/brcm80211/sys/wlc_mac80211.c | 1 -
1 file changed, 1 deletion(-)
--- a/drivers/staging/brcm80211/sys/wlc_mac80211.c
+++ b/drivers/staging/brcm80211/sys/wlc_mac80211.c
@@ -5336,7 +5336,6 @@ wlc_sendpkt_mac80211(wlc_info_t *wlc, vo
fifo = prio2fifo[prio];
ASSERT((uint) PKTHEADROOM(sdu) >= TXOFF);
- ASSERT(!PKTSHARED(sdu));
ASSERT(!PKTNEXT(sdu));
ASSERT(!PKTLINK(sdu));
ASSERT(fifo < NFIFO);
Patches currently in stable-queue which might be from [email protected] are
queue-2.6.37/staging-brcm80211-remove-assert-to-avoid-panic-since-2.6.37-kernel.patch
queue-2.6.37/staging-brcm80211-bugfix-for-softmac-crash-on-multi-cpu-configurations.patch
_______________________________________________
stable mailing list
[email protected]
http://linux.kernel.org/mailman/listinfo/stable
