2.6.37-stable review patch. If anyone has any objections, please let us know.
------------------ From: Ivan Vecera <[email protected]> commit 0d672e9f8ac320c6d1ea9103db6df7f99ea20361 upstream. Without calling of netif_carrier_off at the end of the probe the operstate is unknown when the device is initially opened. By default the carrier is on so when the device is opened and netif_carrier_on is called the link watch event is not fired and operstate remains zero (unknown). This patch fixes this behavior in forcedeth and r8169. Signed-off-by: Ivan Vecera <[email protected]> Acked-by: Francois Romieu <[email protected]> Signed-off-by: David S. Miller <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]> --- drivers/net/forcedeth.c | 2 ++ drivers/net/r8169.c | 2 ++ 2 files changed, 4 insertions(+) --- a/drivers/net/forcedeth.c +++ b/drivers/net/forcedeth.c @@ -5816,6 +5816,8 @@ static int __devinit nv_probe(struct pci goto out_error; } + netif_carrier_off(dev); + dev_printk(KERN_INFO, &pci_dev->dev, "ifname %s, PHY OUI 0x%x @ %d, " "addr %2.2x:%2.2x:%2.2x:%2.2x:%2.2x:%2.2x\n", dev->name, --- a/drivers/net/r8169.c +++ b/drivers/net/r8169.c @@ -3236,6 +3236,8 @@ rtl8169_init_one(struct pci_dev *pdev, c if (pci_dev_run_wake(pdev)) pm_runtime_put_noidle(&pdev->dev); + netif_carrier_off(dev); + out: return rc; _______________________________________________ stable mailing list [email protected] http://linux.kernel.org/mailman/listinfo/stable
