rdma integer overflow http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2010-3865
>From 1b1f693d7ad6d193862dcb1118540a030c5e761f Mon Sep 17 00:00:00 2001 From: Linus Torvalds <[email protected]> Date: Thu, 28 Oct 2010 15:40:55 +0000 Subject: [PATCH] net: fix rds_iovec page count overflow
As reported by Thomas Pollet, the rdma page counting can overflow. We get the rdma sizes in 64-bit unsigned entities, but then limit it to UINT_MAX bytes and shift them down to pages (so with a possible "+1" for an unaligned address). So each individual page count fits comfortably in an 'unsigned int' (not even close to overflowing into signed), but as they are added up, they might end up resulting in a signed return value. Which would be wrong. Catch the case of tot_pages turning negative, and return the appropriate error code. Reported-by: Thomas Pollet <[email protected]> Signed-off-by: Linus Torvalds <[email protected]> Signed-off-by: Andy Grover <[email protected]> Signed-off-by: David S. Miller <[email protected]> --- net/rds/rdma.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-) [ backported version for 2.6.32 (CVE-2010-3865) ] diff -aur linux-2.6.32.28.orig//net/rds/rdma.c linux-2.6.32.28/net/rds/rdma.c --- linux-2.6.32.28.orig//net/rds/rdma.c 2011-01-08 00:08:43.000000000 +0100 +++ linux-2.6.32.28/net/rds/rdma.c 2011-01-15 10:55:03.000000000 +0100 @@ -473,6 +473,12 @@ max_pages = max(nr, max_pages); nr_pages += nr; + + /* CVE-2010-3865 */ + if ((int)nr_pages < 0) { + ret = -EINVAL; + goto out; + } } pages = kcalloc(max_pages, sizeof(struct page *), GFP_KERNEL);
_______________________________________________ stable mailing list [email protected] http://linux.kernel.org/mailman/listinfo/stable
