2.6.35-longterm review patch. If anyone has any objections, please let me know.
------------------ Commit: e82b8e4ea4f3dffe6e7939f90e78da675fcc450e upstream This patch adds IRQ_TIME_ACCOUNTING option on x86 and runtime enables it when TSC is enabled. This change just enables fine grained irq time accounting, isn't used yet. Following patches use it for different purposes. Signed-off-by: Venkatesh Pallipadi <[email protected]> Signed-off-by: Peter Zijlstra <[email protected]> Signed-off-by: Andi Kleen <[email protected]> LKML-Reference: <[email protected]> Signed-off-by: Ingo Molnar <[email protected]> Signed-off-by: Mike Galbraith <[email protected]> Acked-by: Peter Zijlstra <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]> --- Documentation/kernel-parameters.txt | 4 ++++ arch/x86/Kconfig | 11 +++++++++++ arch/x86/kernel/tsc.c | 8 ++++++++ 3 files changed, 23 insertions(+) Index: linux-2.6.35.y/Documentation/kernel-parameters.txt =================================================================== --- linux-2.6.35.y.orig/Documentation/kernel-parameters.txt 2011-03-29 22:51:28.997981183 -0700 +++ linux-2.6.35.y/Documentation/kernel-parameters.txt 2011-03-29 23:03:00.294292640 -0700 @@ -2672,6 +2672,10 @@ disables clocksource verification at runtime. Used to enable high-resolution timer mode on older hardware, and in virtualized environment. + [x86] noirqtime: Do not use TSC to do irq accounting. + Used to run time disable IRQ_TIME_ACCOUNTING on any + platforms where RDTSC is slow and this accounting + can add overhead. turbografx.map[2|3]= [HW,JOY] TurboGraFX parallel port interface Index: linux-2.6.35.y/arch/x86/Kconfig =================================================================== --- linux-2.6.35.y.orig/arch/x86/Kconfig 2011-03-29 22:51:28.997981183 -0700 +++ linux-2.6.35.y/arch/x86/Kconfig 2011-03-29 23:03:00.295292615 -0700 @@ -797,6 +797,17 @@ making when dealing with multi-core CPU chips at a cost of slightly increased overhead in some places. If unsure say N here. +config IRQ_TIME_ACCOUNTING + bool "Fine granularity task level IRQ time accounting" + default n + ---help--- + Select this option to enable fine granularity task irq time + accounting. This is done by reading a timestamp on each + transitions between softirq and hardirq state, so there can be a + small performance impact. + + If in doubt, say N here. + source "kernel/Kconfig.preempt" config X86_UP_APIC Index: linux-2.6.35.y/arch/x86/kernel/tsc.c =================================================================== --- linux-2.6.35.y.orig/arch/x86/kernel/tsc.c 2011-03-29 22:51:28.997981183 -0700 +++ linux-2.6.35.y/arch/x86/kernel/tsc.c 2011-03-29 23:03:00.297292563 -0700 @@ -104,10 +104,14 @@ __setup("notsc", notsc_setup); +static int no_sched_irq_time; + static int __init tsc_setup(char *str) { if (!strcmp(str, "reliable")) tsc_clocksource_reliable = 1; + if (!strncmp(str, "noirqtime", 9)) + no_sched_irq_time = 1; return 1; } @@ -802,6 +806,7 @@ if (!tsc_unstable) { tsc_unstable = 1; sched_clock_stable = 0; + disable_sched_clock_irqtime(); printk(KERN_INFO "Marking TSC unstable due to %s\n", reason); /* Change only the rating, when not registered */ if (clocksource_tsc.mult) @@ -990,6 +995,9 @@ /* now allow native_sched_clock() to use rdtsc */ tsc_disabled = 0; + if (!no_sched_irq_time) + enable_sched_clock_irqtime(); + lpj = ((u64)tsc_khz * 1000); do_div(lpj, HZ); lpj_fine = lpj; _______________________________________________ stable mailing list [email protected] http://linux.kernel.org/mailman/listinfo/stable
